BusyCursor and QPainter fixes for PyPy#2349
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Jun 23, 2022
Merged
Conversation
the previous code relied on QOverrideCursorGuard to do the automatic cleanup. However, that relies on the guard object getting destructed immediately when its reference count drops to zero. Such an assumption is not correct when running on PyPy.
on PyPy, we cannot rely on end() begin called automatically when the QPainter object refcnt drops to zero.
Member
|
Thanks @pijyoi this LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for PySide6 6.3.0 QOverrideCursorGuard #2263 added a hasty fix for the addition of
QOverrideCursorGuard. That fix doesn't work on PyPy. A more proper fix is implemented here.QPainter.end() needs to be called when painting is done.
In both of these cases, the issue has to do with the CPython implementation relying on the objects getting destructed when their refcnt drops to zero.
The fixes here are not specific to PyPy per se, but rather, the issues they fix are exposed when run under PyPy.