Skip to content

add support for PySide6's usage of Python Enums#2329

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
pijyoi:pyside6_pyenum
Jun 17, 2022
Merged

add support for PySide6's usage of Python Enums#2329
j9ac9k merged 1 commit intopyqtgraph:masterfrom
pijyoi:pyside6_pyenum

Conversation

@pijyoi
Copy link
Copy Markdown
Contributor

@pijyoi pijyoi commented Jun 17, 2022

PySide6 is moving to implement Qt enums as Python Enums (like PyQt6).
in PySide6 6.3.1, it is opt-in by setting environment variable PYSIDE63_OPTION_PYTHON_ENUM=1

This PR adds the support by changing the previously PyQt6-specific codepaths to become Python-Enum-specific codepaths. The older implementation of enums on PySide6 continues to work.

in PySide6 6.3.1, it is opt-in by setting environment variable
PYSIDE63_OPTION_PYTHON_ENUM=1
@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Jun 17, 2022

Thanks @pijyoi for the PR!

The changes for the remote graphics view renderView method seem small enough that they don't need their own commit (much less PR).

Merging!

@j9ac9k j9ac9k merged commit 4e350d0 into pyqtgraph:master Jun 17, 2022
@pijyoi pijyoi deleted the pyside6_pyenum branch June 17, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants