ScatterPlotItem: use Format_ARGB32_Premultiplied#2317
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom May 29, 2022
Merged
ScatterPlotItem: use Format_ARGB32_Premultiplied#2317j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
RGB32 and ARGB32_Premultiplied are the preferred formats to use for rendering with QPainter.
Member
|
@danielhrisca @ibrewster you two seem to have some extreme scatter plot performance needs, curious if this change will make a noticeable impact for you. |
Contributor
Author
|
Oh, there should be no measurable impact because the QImage(s) being rendered to are very small. |
Member
|
LGTM @pijyoi nice catch in the docs! Merging. |
Contributor
I've had to step away from the default plotting functionality provided by pyqtgraph. Essentially the following goes on:
If anybody is interested the code is here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://doc.qt.io/qt-5/qimage.html: "Rendering is best optimized to the Format_RGB32 and Format_ARGB32_Premultiplied formats"