test_PlotCurveItem: unset skipFiniteCheck for next test#2313
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom May 26, 2022
Merged
test_PlotCurveItem: unset skipFiniteCheck for next test#2313j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
options passed into setData() are sticky
Member
|
Nice catch @pijyoi Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_PlotCurveItem.pyhas a bug as follows:At the time (8997cfa) of the addition of the 2nd last test with
skipFiniteCheck=True,skipFiniteCheckwas not a sticky option. Thus, the last test automatically reverts toskipFiniteCheck=False.Since the other options of
PlotCurveItemwere sticky in nature, for consistency, 21d77db changedskipFiniteCheckto also be a sticky option. This made the last test to be run withskipFiniteCheck=Trueeven though it was intended to be executed withskipFiniteCheck=False.Note: With the bug, a blank image actually gets generated for the last test but due to the low number of "on" pixels in the reference image, it passes the tolerance test.