Make parameter tree read-only values selectable and copiable#2311
Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom Jun 5, 2022
Merged
Make parameter tree read-only values selectable and copiable#2311j9ac9k merged 3 commits intopyqtgraph:masterfrom
j9ac9k merged 3 commits intopyqtgraph:masterfrom
Conversation
Makes it possible to copy the value
j9ac9k
reviewed
May 29, 2022
Member
|
Hi @ardiloot Thanks for the PR. I left an in-line comment explaining why this is failing on PyQt6, and showed you what adjustment you need to make to make it work for all the bindings pyqtgraph supports. Thanks! |
Contributor
|
I played with this for a bit, seems ok to me! My only thought is that some widgets (i.e. calendar or other things without a display label) won't get these benefits, but subitems are a bit hard to generalize and that can always come later. |
ntjess
approved these changes
Jun 1, 2022
Member
|
Merging, thanks for the PR @ardiloot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
ParameterTreeis used with read-only parameters then it makes sense that it would be possible to select and copy the value of the parameter. Right now the value is not selectable or copiable in any way.