Skip to content

ScatterPlotItem point masking fix#2310

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
ardiloot:scatter-plot-item-fix
May 26, 2022
Merged

ScatterPlotItem point masking fix#2310
j9ac9k merged 1 commit intopyqtgraph:masterfrom
ardiloot:scatter-plot-item-fix

Conversation

@ardiloot
Copy link
Copy Markdown
Contributor

If ScatterPlotItem is transformed by item.setTransform(...) then it starts to act weird (e.g. symbols partly disappearing when zooming in).
Discovered that scatter points are incorrectly filtered by untransformed view box (self.getViewBox().viewRect()), however, view box in the local coordinate system of the item (self.viewRect()) should be used instead (as data is given in the local coordinate system of the item).

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented May 26, 2022

Hi @ardiloot this must have been a nightmare to debug! This PR LGTM, I'll merge shortly.

I wonder if this same fix can be used to resolve #2207 or #2312

@j9ac9k j9ac9k merged commit 944d942 into pyqtgraph:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants