Update exception handling to catch exceptions in threads (py3 change)#2309
Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom May 20, 2022
Merged
Conversation
Member
|
This is the first time in a while I've seen the readthedocs CI fail. Also Py310-PySide6 binding failures are unrelated to this PR. |
Member
Author
|
Oo, threading.excepthook was added in python 3.8. I guess readthedocs is using something older.. |
0f71c64 to
ca5676a
Compare
Member
|
Thanks @campagnola for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python 3, unhandled exceptions inside threads no longer invoke
sys.excepthook; instead they invokethreading.excepthook. Additionally, the signature ofthreading.excepthookis incompatible withsys.excepthook, which necessitates adding new callback registration functions and deprecating the old ones.