Fix #2289 unwanted growing in scene context menu#2306
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom May 18, 2022
Merged
Fix #2289 unwanted growing in scene context menu#2306j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Add extra condition to menu action logic that checks if menus were already previously inserted
Member
|
Thanks @ntjess this LGTM! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2289
Add extra condition to menu action logic that checks if menus were already previously inserted
This fix makes the decision to add all new actions at the end of the menu to preserve ordering of previously inserted objects. Note that other fixes could be chosen instead, i.e. always clear and reload the menu.