Address #2303 unapplied pen parameter constructor options#2305
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom May 18, 2022
Merged
Address #2303 unapplied pen parameter constructor options#2305j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
`mkPen` ignores kwargs it doesn't recognize. Thus, additional options can be safely ignored when all opts are passed
Member
|
Hi @ntjess Thanks for the PR; would you mind renaming the title of the PR as it will be incorporated into the automatic release notes later? |
Member
|
LGTM, thanks @ntjess for the quick PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2303
Initial pen options specified in
**optswere ignored in the pen parameter constructure. These can just be passed directly to the initialized pen.