Issue #2203 Potential Fix: Disabled FlowchartCtrlWidget.nodeRenamed o…#2301
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jun 18, 2022
Merged
Issue #2203 Potential Fix: Disabled FlowchartCtrlWidget.nodeRenamed o…#2301j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
…Renamed on Input/Output node In [FlowechartCtrlWidget.nodeRenamed](https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/flowchart/Flowchart.py#L698), the `items` dictionary is being used, but the Input and Output nodes are not added to `items` due to the if statement at [line 195](https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/flowchart/Flowchart.py#L195). I added the logic of excluding the Input and Output nodes to [Flowchart.nodeRenamed](https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/flowchart/Flowchart.py#L222). This maintains current functionality according to issue pyqtgraph#2203, unclear if this is expected functionality.
Member
|
Thanks for the PR, sorry I didn't get to this earlier, the flowchart module doesn't get a lot of attention so I certainly appreciate the contribution to it. LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n Input/Output node
In FlowechartCtrlWidget.nodeRenamed, the
itemsdictionary is being used, but the Input and Output nodes are not added toitemsdue to the if statement at line 195. I added the logic of excluding the Input and Output nodes to Flowchart.nodeRenamed.This maintains current functionality according to issue #2203, unclear if this is expected functionality.