change the libOrder to favor Qt6 by Wubbzi · Pull Request #2157 · pyqtgraph/pyqtgraph

Wubbzi · 2021-12-16T21:41:44Z

I'd like to propose changing the order in which Qt bindings are selected when one is not specified by the user.

Changing the libOrder to favor the newer Qt6 bindings is inevitable and I think now is as good of a time as any to do it.

Pros

Since last month, when I took an interest in pg, there have been a couple of issues that were caused by the PySide2 bindings, maybe more to come. While the issues will still probably need to be addressed, the number of users who see run into the issue will be less.
The vast majority of users will never see updates or bug fixes for these releases.
Qt 6.2 is an LTS build.
Some people have more than one binding installed and It's probably confusing to them why the newer binding they've installed isn't being used. I don't think everyone who uses the library is a programmer or has the time to dig into the code to figure it out why this is happening.

Cons

New versions could cause bigger issues than older versions(there is always the option of settingPYQTGRAPH_QT_LIB if this does happen to users with multiple versions of bindings)

Does anyone have a preference on the order of the v6 bindings? Right now, both versions have about the same number of users going based on the downloads.
https://pypistats.org/packages/pyside6
https://pypistats.org/packages/pyqt6

pijyoi · 2021-12-17T03:34:19Z

If you make this change, you may also want to modify the drop-down list in exampleLoaderTemplate.ui to match the order (for cosmetic reasons).

Wubbzi · 2021-12-17T18:06:49Z

@pijyoi I could do that.

Could we get rid of 'default' too? The UX could be better if we set the index to the correct version in ExampleApp before the launch.

pijyoi · 2021-12-17T21:39:15Z

Sure. But correct version means matching it against PYQTGRAPH_QT_LIB and also the bindings that are found to be installed.

pijyoi · 2021-12-20T12:58:44Z

pyqtgraph/examples/ExampleApp.py

 from collections import OrderedDict
 from functools import lru_cache

+import pkg_resources


Can it be assumed that this is available for use?

Not as sure as I am about pkgutil so we can use that with minimal changes instead of pkg_resources.

pijyoi · 2021-12-20T13:29:59Z

pyqtgraph/examples/ExampleApp.py

+
+    def showEvent(self, event) -> None:
+        super(ExampleLoader, self).showEvent(event)
+        disabledColor = pg.mkColor(QtCore.Qt.GlobalColor.red)


may I suggest that this PR not change the public API at the same time?
QtGui.QColor(QtCore.Qt.GlobalColor.red) would seem to suffice.

pijyoi · 2021-12-21T07:43:49Z

So the original code populates the combo box through the.ui file. I was thinking, if we are going to take the trouble to programmatically mark out bindings that aren't available, would it make more sense to programmatically populate the combo box from the start?

And going even further, why not just populate the combo box only with the bindings that are available? Of course, showing the not available bindings does give an indication to the user that pyqtgraph works with multiple bindings.

Wubbzi · 2021-12-22T00:25:27Z

if we are going to take the trouble to programmatically mark out bindings that aren't available, would it make more sense to programmatically populate the combo box from the start?

There isn't a good reason that I can think of for us not to do it this way. I'm pretty sure it would only be 1 line.

edit: I went ahead and did this, if for no other reason than it will be easier to change/update in the future.

And going even further, why not just populate the combo box only with the bindings that are available? Of course, showing the not available bindings does give an indication to the user that pyqtgraph works with multiple bindings.

Before marking the missing bindings in red, I was removing them, but like you said, a user might not know they have the option of using other bindings.

I think this is the better option. The one thing I'm not sure about is disabling the binding in addition to coloring it red. I think most people will understand it means the binding isn't installed, but maybe it would be better to mark the binding in red and not disable it, so they can see the traceback when an example is run.

Wubbzi

When uninstalling PyQt5/6 with pip, there are other installed dependencies left behind, which means you will be able to import PyQt5 but QtCore/QtWidgets, etc will be missing and cause the library to fail to load.

…plate files

…d item when launched

…ge the color, and set a tooltip on that item in the combobox.

…time and when font size is changed.

…kColor

j9ac9k · 2022-09-27T04:55:12Z

Hi @Wubbzi, hope you don't mind that I took over this PR, I really wanted this diff in 0.13.0 release; but there were a number of merge conflicts.

Thanks for the PR!

pijyoi reviewed Dec 20, 2021

View reviewed changes

Wubbzi commented Dec 22, 2021

View reviewed changes

Wubbzi and others added 16 commits September 26, 2022 20:09

change the libOrder to favor Qt6

220bb74

remove default option from binding combo in the UI file and regen tem…

c934648

…plate files

set binding combobox item with text matching QT_LIB to be the selecte…

a70d7e2

…d item when launched

remove the font weights QtCreator forced into the UI file.

e60d209

add option for Qt.GlobalColor to mkColor

d31dc25

find installed bindings. If a binding is not installed, disable, chan…

65da201

…ge the color, and set a tooltip on that item in the combobox.

simplify loadFile method

dd44b36

set codeView tabStopDistance to 4 spaces.

de79fe2

create method to set codeView tabStopDistance to 4 spaces. set at run…

b1e3b20

…time and when font size is changed.

switch pkg_resources for pkgutil and remove GlobalColor option from m…

b937374

…kColor

workaround for bug that happens when PyQt6 is uninstalled.

55a85e8

remove bindings from combobox in ui files.

038b30f

add items to combobox in ExampleApp.py

fa248ef

Undo changes to functions.py

c6e24da

Do not specify the font width

e529ba2

Make sure QT_LIB is available

22d541d

j9ac9k merged commit c9c89db into pyqtgraph:master Sep 27, 2022

veractor mentioned this pull request Aug 26, 2023

Docs: Update Qt binding selection details #2807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

change the libOrder to favor Qt6#2157

change the libOrder to favor Qt6#2157
j9ac9k merged 16 commits intopyqtgraph:masterfrom
Wubbzi:binding_load_order

Wubbzi commented Dec 16, 2021 •

edited

Loading

Uh oh!

pijyoi commented Dec 17, 2021

Uh oh!

Wubbzi commented Dec 17, 2021

Uh oh!

pijyoi commented Dec 17, 2021

Uh oh!

pijyoi Dec 20, 2021

Uh oh!

Wubbzi Dec 20, 2021

Uh oh!

pijyoi Dec 20, 2021

Uh oh!

pijyoi commented Dec 21, 2021

Uh oh!

Wubbzi commented Dec 22, 2021 •

edited

Loading

Uh oh!

Wubbzi left a comment

Uh oh!

j9ac9k commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Wubbzi commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pijyoi commented Dec 17, 2021

Uh oh!

Wubbzi commented Dec 17, 2021

Uh oh!

pijyoi commented Dec 17, 2021

Uh oh!

pijyoi Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

Wubbzi Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

pijyoi Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

pijyoi commented Dec 21, 2021

Uh oh!

Wubbzi commented Dec 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wubbzi left a comment

Choose a reason for hiding this comment

Uh oh!

j9ac9k commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wubbzi commented Dec 16, 2021 •

edited

Loading

Wubbzi commented Dec 22, 2021 •

edited

Loading