Fire correct signal type for checklist value changing#2147
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Dec 11, 2021
Merged
Fire correct signal type for checklist value changing#2147j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Not sure how I made it this far without noticing... Forwarding changing signals from checklist children show "true"/"false" as changing values, not self's value. This fixes the problem. Also, "value" should represent the stored `self.opts['value']` instead of the transient widget value. I fixed this with a separate `childrenValue` function which contains the transient widget value
Member
|
Thanks @ntjess this looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how I made it this far without noticing... Forwarding changing signals from checklist children show "true"/"false" as changing values, not self's value. This fixes the problem.
Also, "value" should represent the stored
self.opts['value']instead of the transient widget value. I fixed this with a separatechildrenValuefunction which contains the transient widget value