win32 np.clip slowness fixed in numpy#2125
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 28, 2021
Merged
Conversation
Member
|
Thanks for sticking w/ this issue @pijyoi ! LGTM, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1641 added a workaround for
np.clipslowness when running on Windows platform.The cause was found and fixed in numpy/numpy#20134.
numpy/numpy#20234 is also relevant. (bump compiler to MSVC 2019).
The two above-mentioned PRs are included in numpy 1.22. Thus the workaround can and should be avoided when using numpy >= 1.22. Note that with numpy 1.22,
np.clipnow runs equally fast on both Windows and Linux (WSL2) on the same machine, as would be expected.Note that the slowness was not a Windows platform issue, it was a code + compiler issue.
For testing the speed difference between different versions of numpy, the script in numpy/numpy#18673 can be used.
Numpy 1.22.0rc1 can currently be downloaded from pypi.