set PLATFORM=offscreen in binder/start#2106
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Nov 16, 2021
Merged
Conversation
Contributor
pijyoi
commented
Nov 16, 2021
- Found the correct place to set environment variables for binder.
- Update simple image example to have a ColorBarItem
- better demonstrates the interactive capability
Member
|
Hi @pijyoi this LGTM. I noticed that the example with the notebook sliders to adjust the colors of the image was removed, I assume this was done because scipy was removed as a dependency in binder? How would you feel about re-introducing an example like that (doesn't have to be part of this PR). |
Contributor
Author
The dependency on scipy was one reason. Another was that it was a poor man's version of The image example in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.