Be lazier about importing h5py#2096
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 15, 2021
Merged
Conversation
We discovered recently bad interactions between pytables and h5py resulting in the inability to import one after the other had been imported. This takes a step towards pyqtgraph not being a confounding variable in that situation when it doesn't need to be. Note that h5py is still imported in MetaArray, so until that is removed, this doesn't actually solve the issue of h5py being loaded when pyqtgraph is imported, but once metaarray is removed as planned, this is the only remaing library (non-example) code that uses h5py directly.
Member
|
Thanks @ksunden ! Merging! EDIT: merging after CI finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered recently bad interactions between pytables and h5py resulting in the inability to import one after the other had been imported. This takes a step towards pyqtgraph not being a confounding variable in that situation when it doesn't need to be. Note that h5py is still imported in MetaArray, so until that is removed, this doesn't actually solve the issue of h5py being loaded when pyqtgraph is imported, but once metaarray is removed as planned, this is the only remaing library (non-example) code that uses h5py directly.