Skip to content

Add some helpful exceptions for invalid inputs to methods#2092

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
ksunden:uninit_var
Nov 15, 2021
Merged

Add some helpful exceptions for invalid inputs to methods#2092
j9ac9k merged 1 commit intopyqtgraph:masterfrom
ksunden:uninit_var

Conversation

@ksunden
Copy link
Copy Markdown
Contributor

@ksunden ksunden commented Nov 15, 2021

Raise ValueError/TypeError instead of relying on NameError being raised later on in less helpful contexts to avoid uninitialized variables.

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Nov 15, 2021

Love fixing static code error issues! Thanks @ksunden for the PR!

@j9ac9k j9ac9k merged commit 1ba9964 into pyqtgraph:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants