Skip to content

add check for roi scene#2083

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
hyperiongeo:1961_fix_roi_scene_crash
Nov 14, 2021
Merged

add check for roi scene#2083
j9ac9k merged 1 commit intopyqtgraph:masterfrom
hyperiongeo:1961_fix_roi_scene_crash

Conversation

@hyperiongeo
Copy link
Copy Markdown
Contributor

@hyperiongeo hyperiongeo commented Nov 13, 2021

Seems straight-forward - added a check if scene is not None.

fixes #1961

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Nov 13, 2021

Hi @hyperiongeo

Thanks for the PR, this issue should fix an exiting open issue right? If so could you amend your post to include

Fixes #issue-number

This way, when this PR is merged, the issue will automatically close the issue linking to this PR as the fix 👍🏻

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Nov 14, 2021

Confirmed this fixed the issue, thanks for the PR @hyperiongeo merging!

@j9ac9k j9ac9k merged commit 7867958 into pyqtgraph:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ROI removeHandle fails before ROI is added to scene

2 participants