Improved error message for invalid PYQTGRAPH_QT_LIB#2077
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Nov 13, 2021
Merged
Improved error message for invalid PYQTGRAPH_QT_LIB#2077j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
Member
|
👋🏻 @max-radin So we might be about to cause some merge conflicts on you, as we're just about to merge #2002 and #1915 which I believe change some of the lines you're proposing to change. We're going to merge those shortly so we'll see soon enough. Sorry for the inconvenience and thanks for the PR! |
Member
Member
|
Merging, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a more informative error message if the module specified by PYQTGRAPH_QT_LIB cannot be found.
(However there's a few edge cases where this solution could be misleading, for example if the Qt module was installed but was missing a submodule.)