implement glInfo without PyOpenGL#2073
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 12, 2021
Merged
Conversation
Member
|
Thanks for this @pijyoi this LGTM 👍🏻 |
Contributor
Author
|
PySide6 seems to be getting a working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Actions has moved to macOS Big Sur for some runners. This causes:
PyOpenGLwhen it executespyqtgraph.opengl.glInfo.This PR fixes (1) by reimplementing glInfo without using PyOpenGL. (2) is fixed by updating the skip constraints.
It adds some more useful info like VENDOR, RENDERER and isOpenGLES.
However, it loses the maximum TEXTURE size info.
This is because PySide bindings do not have a working glGetIntegerv function.
Note: The file was moved from
pyqtgraph/opengl/glInfo.pytopyqtgraph/util/glinfo.pybecausepyqtgraph/opengl/__init__.pyalready triggers import of PyOpenGL.