Maintain limits on ViewBox scaling#2054
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 6, 2021
Merged
Conversation
Member
|
Upon further check for adding a test, I noticed the axes change, but the rendering doesn't; short of some kind of Thanks for the PR @NilsNemitz and thanks for generating the example of the issue in #2001 @pijyoi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #2001 , the absolute limits of values represented by double-precision floating-point values can be reached very quickly by zooming out in logarithmic mode: The
AxisItems start calculating with out of range values when the logarithmic representation exceeds +/-308, which can be reached with two or three spins of the mouse wheel.In normal mode, it takes a little longer to get there, but it is similarly possible to create failures by simply zooming out too far.
This PR initialized the range limits in normal mode to be +/-1E307 (close to the absolute range limits, with a slight extra margin to avoid earlier out-of-range values in internal calculations. It also applies additional limits of about +/308 to the allowed ViewBox scaling range when in logarithmic mode, corresponding to log10 of the range limit.
Downsides:
I am hoping for comments.
This closes #2001.