Disable and comment the prepareForPaint call in ViewBox.update()#2053
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 6, 2021
Merged
Disable and comment the prepareForPaint call in ViewBox.update()#2053j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Thanks for this @NilsNemitz I appreciate the comment you put in the code here; so much of the code in ViewBox.py has so much in the way of subtle impacts. Only question I have is if there is an "easy" test to add to test for that catches the error that was detailed to |
Member
|
I was trying to do an "easy" test, but noticed the axis coordinates were changing w/ the zoom behavior, but the image was not, so short of some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #2029, where a recent change to ViewBox was found to result in an unwanted reset of viewing range with each update of data. All the credit for experimentation and triangulating the problem goes to @pijyoi , @j9ac9k and @JeanBilheux .
But since the problem was introduced as part of my PR #1992, I thought I should propose a PR to fix it.
This change reverts the addition of a
prepareForPaint()call inViewBox.update(). This was added since it appeared to result in a more user-friendly failure mode for the basically unsupported case of data with infinite values, at least on OSX. This addition was not part of the main functionality of #1992, but no side effects were known or expected at the time.But since such side effects clearly exist after all, I believe a revert to the previous state is the best solution.
This was found to solve the issue in #2029 (comment)_
Closes #2029