Factor out palette-related code from "named colors" PR#1921
Draft
NilsNemitz wants to merge 1 commit intopyqtgraph:masterfrom
Draft
Factor out palette-related code from "named colors" PR#1921NilsNemitz wants to merge 1 commit intopyqtgraph:masterfrom
NilsNemitz wants to merge 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Hi @NilsNemitz this PR looks like it needs a rebase given all the reshuffling of stuff we've done over the last few months, sorry for the head-ache! Let me know if I can help with that effort. |
Contributor
Author
|
Heh, thanks for the concern, but unfortunately, this is the least of the worries for this PR. I put this here as a PR to have a basis for discussion, but in all honesty, work has stalled on this a little, and I am still trying to figure out what bits need to go where in order to give this at least a semblance of elegance. I think we might close this PR for now, keep the numbers looking good. |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work-in-progress code that extracts (and hopes to clean up) the main palette management code from my earlier PR #1625.
Palette colors and UI monochromes are now sampled from color maps, which means that generation of an arbitrary number of plot colors by
functions.intColor()and the monochrome generation for float values passed tomkColor()can be maintained while matching the alternative color schemes.Once the code is in better shape, it should allow color presets (to be selected before plots are initialized) with less complexity and bugs than the original proposal... and will hopefully be less painful to review :)