remote: exchange pids if running in Windows venv#1860
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jun 22, 2021
Merged
remote: exchange pids if running in Windows venv#1860j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Thanks for jumping on this @pijyoi ! I appreciate the comment/link to the upstream issue. Merging! |
Contributor
|
@j9ac9k @pijyoi This PR does not solve issue #1052. The reason is that even though I am working in a virtual env the value of With Google I found an alternative method to detect a venv: Can I make a PR to update the check with this method or are there other considerations? |
Member
|
A PR along with steps to reproduce the issue so we can replicate would be appreciated! |
Contributor
Author
|
The docs https://docs.python.org/3/library/sys.html#sys.base_prefix does indicate that the suggested method would work. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works around the issue where the remote rendering examples (RemoteGraphicsView.py and RemoteSpeedTest.py) do not work under Windows platform when run under a venv.
Would fix #1052
Technically, the workaround could be applied for all platforms, venv or not. However, it is probably safer to only apply it where it is needed.