rescaleData : workaround np.clip regression since numpy 1.17#1632
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 14, 2021
Merged
rescaleData : workaround np.clip regression since numpy 1.17#1632j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Tagging @NilsNemitz as the dynamic rescaling using Thanks for tracking this down @pijyoi This LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy has an open issue where
np.clip()has a large performance regression since 1.17 : numpy/numpy#14281This affects pyqtgraph's
rescaleData()and accounts for a large chunk of the time taken formakeARGB().This PR uses the workaround described in numpy issue above.
Using the "Code to reproduce" example given in #1590, performance improvements of this PR can be observed.