combine levels and lut only if both are present#1630
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 14, 2021
Merged
Conversation
previously, if levels was present but lut was not, levels would be converted into lut.
Member
|
Thanks @pijyoi for narrowing down the code-paths and identifying unnecessary computation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a partial fix for #1590.
Previously, if
levelswas present butlutwas not,levelswould be converted intolut.i.e. levels and ~lut --> ~levels and lut
However, since makeARGB always applies levels, this becomes a pessimization.
i.e. both levels and lut are now applied.
This PR changes it to become: levels and lut --> ~levels and lut
With this fix, in the (perhaps common) use case where the user does not provide a lut, the pessimization will no longer get triggered.