Skip to content

Workaround for cupy indexing bug#1595

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
outofculture:cupy-bug-workaround
Feb 20, 2021
Merged

Workaround for cupy indexing bug#1595
j9ac9k merged 1 commit intopyqtgraph:masterfrom
outofculture:cupy-bug-workaround

Conversation

@outofculture
Copy link
Copy Markdown
Contributor

The bug was caught by running our tests against a cupy backend, so yay, us!

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Feb 20, 2021

Thanks for tracking this down @outofculture ! This LGTM, merging.

@j9ac9k j9ac9k merged commit 3eda637 into pyqtgraph:master Feb 20, 2021
@outofculture outofculture deleted the cupy-bug-workaround branch May 6, 2021 00:37
@NilsNoreyson
Copy link
Copy Markdown

Hello,
as noted here:
cupy/cupy#4693 (comment)
the "indexing bug" which made this workaround necessary seems to be solved in CuPy now.
Actually I had to revert this workaround back to its previous version to get the masking working properly with the 10.6.0 version of cupy.
Would it make sense to revert this PR and take the workaround out again?

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Apr 12, 2023

Thanks tracking this down @NilsNoreyson !

@outofculture you good with reverting this?

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Apr 12, 2023

I'm actually a little reluctant to outright do away w/ the old codepath, maybe we have an if statement depending on the version of cupy? After we get to 2 years since cupy 10.0 was released (what NEP-29 suggests we deprecate numpy versions) we then get rid of the old method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants