You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
as noted here: cupy/cupy#4693 (comment)
the "indexing bug" which made this workaround necessary seems to be solved in CuPy now.
Actually I had to revert this workaround back to its previous version to get the masking working properly with the 10.6.0 version of cupy.
Would it make sense to revert this PR and take the workaround out again?
I'm actually a little reluctant to outright do away w/ the old codepath, maybe we have an if statement depending on the version of cupy? After we get to 2 years since cupy 10.0 was released (what NEP-29 suggests we deprecate numpy versions) we then get rid of the old method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was caught by running our tests against a cupy backend, so yay, us!