MAINT: Post 0.11.1 release, drop py2, qt4#1473
Conversation
This focuses on distribution, tests, and docs. This may not be comprehensive, but covers the cases I found by looking and a few greps Noteably, this does not change any actual internal code yet, to avoid merge conflicts with pending PRs.
|
Nep-29 says we should not support 3.6, but 3.7+ From this point..
I'm working on migrating our CI to GitHub actions in another PR.
…On Sat, Dec 19, 2020 at 10:58 PM lidstrom83 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#1473 (comment)>:
> @@ -19,10 +19,23 @@ heavy leverage of numpy for number crunching, Qt's GraphicsView framework for
Requirements
------------
-* Python 2.7, or 3.x
+pyqtgraph has adopted [NEP 29](https://numpy.org/neps/nep-0029-deprecation_policy.html).
+
+This project supports:
+
+* All minor versions of Python released 42 months prior to the project, and at minimum the two latest minor versions.
+
+* All minor versions of numpy released in the 24 months prior to the project, and at minimum the last three minor versions.
+* All minor versions of Qt 5 currently supported by upstream Qt (Note, Qt 6 support is not yet implemented)
+
+
+Currently this means:
+
+* Python 3.7+
Here too. That or these are correct and the matrix needs to drop 3.6.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1473 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE5Z7RMO7FKRPWZA5DO3ODSVWOBXANCNFSM4VCYGJTQ>
.
|
I noticed that and also saw you were working on the CI migration after making my dumb comments that I deleted :) |
My PR isn't a sure thing yet, there are some configs that are still being problematic, it may take me a while to resolve. |
| @@ -9,9 +9,6 @@ envlist = | |||
| ; qt 5.9.7 (LTS) | |||
| py36-{pyqt5,pyside2}_59_conda | |||
There was a problem hiding this comment.
I am ok with testing PyQt5.9 in tox; but we should test it with python 3.7.
I suggest removing all references to py36 from here, and adding some py39 references where appropriate.
|
This is such a relief to merge this... |
|
thank you @ksunden for helping make this happen! |
This focuses on distribution, tests, and docs. This may not be comprehensive, but covers the cases I found by looking and a few greps
Noteably, this does not change any actual internal code yet, to avoid merge conflicts with pending PRs.