Call GraphicsItem.viewTransformChanged()#1413
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Oct 22, 2020
Merged
Conversation
Member
Author
|
did a quick run through of these, the infinite line labels did not behave as intended, so I made the call to the GraphicsItem method from there too... I think this should do it... |
Member
Author
|
Fixes #1412 |
dgoeries
reviewed
Oct 22, 2020
| ev.acceptDrags(QtCore.Qt.LeftButton) | ||
|
|
||
| def viewTransformChanged(self): | ||
| GraphicsItem.viewTransformChanged(self) |
Contributor
There was a problem hiding this comment.
I did not look into the code (example), but normally the TextItem.viewTransformChanged should do the job. Did you check if the order is important?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1391 got a bug report on slack about infinite lines not extending the height of the view; this was due to some cache handling in GraphicsItem; fix was just to call the inherited viewTransformChanged method from GraphicsItem for InifiniteLine.
I'm wondering if we should take a look at some of the other places we call out
viewTransformChangedexplicitly.Other places we call it include: