Skip to content

handle case of version string having no '+'#1402

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k:get-version-string-handling-tag
Oct 18, 2020
Merged

handle case of version string having no '+'#1402
j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k:get-version-string-handling-tag

Conversation

@j9ac9k
Copy link
Copy Markdown
Member

@j9ac9k j9ac9k commented Oct 18, 2020

Ran into this issue while testing out another unrelated issue. I went to check out tag pyqtgraph-0.11.0 and did python.setup.py install and got the following error:

$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 70, in <module>
    version, forcedVersion, gitVersion, initVersion = helpers.getVersionStrings(pkg='pyqtgraph')
  File "tools/setupHelpers.py", line 470, in getVersionStrings
    _, local = gitVersion.split('+')
ValueError: need more than 1 value to unpack

The issue here is that gitVersion is reporting the version 0.11.0 with no +. We can work around this by using str.partition("+") instead which won't blow up should a + not be present.

@j9ac9k j9ac9k merged commit 9f86eef into pyqtgraph:master Oct 18, 2020
@j9ac9k j9ac9k deleted the get-version-string-handling-tag branch October 18, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant