SignalProxy: Correct initialization without slot argument and tests#1392
Merged
j9ac9k merged 13 commits intopyqtgraph:masterfrom Oct 13, 2020
Merged
SignalProxy: Correct initialization without slot argument and tests#1392j9ac9k merged 13 commits intopyqtgraph:masterfrom
j9ac9k merged 13 commits intopyqtgraph:masterfrom
Conversation
Contributor
Author
|
Sometimes ... |
Contributor
Author
|
Finally, I learned why I never used PySide :-). Maybe an integrator has a look? |
Member
|
Thanks for the PR @dgoeries especially for the tests! We have a small handful of PRs that are effectively waiting for the post-0.11 release where we no longer support Qt4 and Py2, and given the issues with PySide .... that said, given this addresses an issue that is facing all versions, I'm not opposed to merging right away. @campagnola @ixjlyons @ksunden you all have opinions? |
j9ac9k
reviewed
Oct 13, 2020
j9ac9k
reviewed
Oct 13, 2020
Member
|
Thanks for the PR @dgoeries this looks good to me, only changes I request is converting the |
Contributor
Author
|
thanks for the review! Changes were made accordingly |
Member
|
Thanks for the update @dgoeries , this looks good to me, I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #1178