GraphicsView: Set a transparent background palette#1383
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 13, 2020
Merged
GraphicsView: Set a transparent background palette#1383j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Contributor
Author
|
It is a different data update, that is why the Y axis has different values. |
Member
|
Thanks for the PR @dgoeries I'm good with this, but will wait for some more input before merging. |
Contributor
Author
|
thanks very much! |
Member
|
Unfortunately this PR broke some Qt4 functionality (can't wait to kill off Qt4 support!); I'm going to submit another PR putting this change under an |
Member
|
Unfortunately this change has made some significant performance regressions on scatter plots. I'll dive into the Qt docs to see if there is some kind of alternative/workaround, but we may have to undo this change. |
Contributor
Author
|
That would be sad, but how? I don't see any difference in fps with the benchmark tool |
Contributor
Author
|
Testing 0.11.0 with and without this and I see a performance drop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background of the GraphicsView is blocking other features. In my example a grid in a designer. On the road to set a single viewbox background to white without affecting others:
Before:
After: