AxisItem: Account for empty strings in the visibility of text and units#1367
Merged
j9ac9k merged 5 commits intopyqtgraph:masterfrom Oct 15, 2020
Merged
AxisItem: Account for empty strings in the visibility of text and units#1367j9ac9k merged 5 commits intopyqtgraph:masterfrom
j9ac9k merged 5 commits intopyqtgraph:masterfrom
Conversation
Member
|
Changed the base, I really should update the |
Contributor
Author
|
Thanks! I believe I have to look at the tests. An exporter is failing now ... |
768d1e6 to
c9aa7ee
Compare
Contributor
Author
|
All tests pass through now. I had to cleanup a bit the AxisItem and disentangle the There might be a slight regression potential depending on how the method was used. I put this to expected behavior (at least for me, Can you have a look again please. |
Member
Member
|
After taking another look, I think this is good, thanks again for the PR @dgoeries merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
textandunits