Fixed bug where removeTempArea would be called on home even if it was not defined#1349
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Oct 14, 2020
MitchelPaulin:develop
Merged
Fixed bug where removeTempArea would be called on home even if it was not defined#1349j9ac9k merged 2 commits intopyqtgraph:masterfrom MitchelPaulin:develop
j9ac9k merged 2 commits intopyqtgraph:masterfrom
MitchelPaulin:develop
Conversation
Member
|
I really should sync up develop branch w/ master, ... as the current state of develop is rather broken. I should also update the contributing guide to suggest creating PRs to merge with master. Anyway let me fix the target branch and let CI rerun and do its thing... EDIT: BTW thanks for the PR @MitchelPaulin ...I'll let the CI re-run. |
Contributor
Author
|
@j9ac9k Everything look good? |
Member
Member
|
Hi @MitchelPaulin sorry it's taken me so long to follow up. Moving takes forever... now that I'm taking a closer look at this, I have one suggestion, which I'll make in-line. Thanks again for the PR and sorry for the delayed reply. |
j9ac9k
reviewed
Oct 14, 2020
Member
|
LGTM! Thanks for the change! Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an issue where after poping a graph from a dock area I would get an error about calling removeTempArea on None. This seems to have fixed the problem.