Conversation
74c8e21 to
a1b9630
Compare
* added docstring * fixed handling of QVector3D args (cannot list() them) * refactor to no longer need return statements
a1b9630 to
75899f0
Compare
|
Rebased onto master; turns out the refactor had happened once before, but this one is more accurate. |
ixjlyons
left a comment
There was a problem hiding this comment.
A few nit-pick comments on the docs, but otherwise this looks good to me.
pyqtgraph/Vector.py
Outdated
|
|
||
| ============== ================================================================================================ | ||
| **Arguments:** | ||
| *args* Could be any of: |
There was a problem hiding this comment.
Vector isn't currently in the docs, but there should be few more spaces introduced before "Could". It should align with the = after the gap in the table borders. Please also add an empty line after this one - I'm not sure exactly why but RST/sphinx seems to prefer it this way for bulleted lists.
There was a problem hiding this comment.
Thanks; I was bumbling about for the rules there.
pyqtgraph/Vector.py
Outdated
| * 1 QSizeF (`0` assumed for z) | ||
| * 1 QPointF (`0` assumed for z) | ||
| * Any other valid QVector3D init args. | ||
| ---------------------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
I think this line can be removed.
pyqtgraph/Vector.py
Outdated
| ============== ================================================================================================ | ||
| **Arguments:** | ||
| *args* Could be any of: | ||
| * 3 numerics |
There was a problem hiding this comment.
It's probably obvious, but maybe add a parenthetical (x, y, and z) at the end of this line.
|
I've acted on all the comments. |
|
Looks good. Thanks @outofculture |
Vector.__init__improvementsAlso add Pa to the list of units.