convert connect='finite' to connect=ndarray#1286
convert connect='finite' to connect=ndarray#1286pijyoi wants to merge 3 commits intopyqtgraph:masterfrom
Conversation
|
Looks like in merging #1283 we created a merge conflict |
41a8022 to
c0a8bd4
Compare
|
I have rebased and also modified the code to output the new ndarray syntax required by #1283 |
|
This fixes my problem in #1057 with a slight modification. Line 1490: |
|
@summoningdark , thanks for the fix. I have incorporated it. |
|
@pijyoi i assigned @campagnola to these issues given he's the author of 1 of the PRs and the low level nature of these changes. Last I heard he wanted to do some performance evaluations on the proposals (iow we haven't forgotten about this PR (or the other ones), a solution with these fixes will be in the next release. |
|
Hi @pijyoi with merging #1287 I believe the base issue that this PR was meant to address is now resolved. Sorry this took us so long to follow up on. I'm going to close out this PR, but if something isn't working as expected, or this PR covers a use-case that #1287 does not, let me know and I'll re-open. |
Qt no longer accepts non-finite values for plotting as seen here:
https://github.com/qt/qtbase/blob/f6b7b64ed0168038e365b936a1daea9b3bcda335/src/gui/painting/qpainterpath.cpp#L2537
This would prevent PlotCurveItem.setData(connect='finite') from working.
This commit converts a call using connect='finite' to the equivalent call using connect=ndarray with all the non-finite elements removed.
Related to PR #1058
Related to issue #1057