ParameterTree: Fix custom context menu#1225
Merged
j9ac9k merged 2 commits intopyqtgraph:developfrom Jun 6, 2020
Merged
Conversation
This issue was introduced in merging develop into pyqtgraph#1175. While refactoring for the merge, the change in namespace was not correctly attributed, leading to the parameter `opts` to be assumed in local namespace when it isn't.
Using `opts` as alias for `self.param.opts`, following the style of `updateFlags`.
Contributor
Author
|
The last commit adds |
Member
|
This LGTM, love your simple patch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was introduced in merging develop into #1175.
While refactoring for the merge, I did not attribute the change in namespace correctly, leading to the parameter
optsto be assumed in local namespace when it isn't.