Identify pyqt5 515 ci issue#1221
Merged
j9ac9k merged 11 commits intopyqtgraph:developfrom Jun 1, 2020
Merged
Conversation
Member
Author
|
BTW this PR should most definitely be squashed when merged.... |
Member
Author
|
CI is all green again, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1220
With PyQt5 5.15.0 released, our CI system failed at the debug stage. Some googling turned up QTBUG-84489 which the author there reported this being a new issue with Qt 5.15.0. I suspect we'll likely see the same thing with PySide2 (speaking of which, we should add a "latest" PySide2 pipeline).
I also renamed the Python38-PyQt-5.14 pipeline to Python38-PyQt-Latest (as that is what it really is).