Add support for running pyside2-uic binary to dynamically compile ui files#1211
Merged
campagnola merged 8 commits intopyqtgraph:developfrom Jun 4, 2020
Merged
Add support for running pyside2-uic binary to dynamically compile ui files#1211campagnola merged 8 commits intopyqtgraph:developfrom
campagnola merged 8 commits intopyqtgraph:developfrom
Conversation
Member
|
Hmm, all linux CI runs are failing, but not just on this PR, but on another one as well... wonder if there is some upstream issue. |
Member
|
Closing/Opening to re-trigger CI run |
Contributor
|
#1102 is closed, does that affect this PR? |
Member
|
@2xB that was my fault, I didn't verify the solution worked entirely and closed the issue, turns out we do need a change in the pyqtgraph code-base |
j9ac9k
reviewed
Jun 3, 2020
Member
|
I think this branch is ready to merge @campagnola ... figured we should at least test the new loadUiType functionality in the CI platform, so I added a pyside2-latest pipeline (now up to 18, yay!) |
Member
Author
|
Thanks @j9ac9k ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1102