Merged
Conversation
Member
|
Closing/Re-Opening to see if the CI system will grace us with different behavior |
j9ac9k
reviewed
May 30, 2020
pyqtgraph/imageview/ImageView.py
Outdated
| axes = (self.axes['x'], self.axes['y']) | ||
|
|
||
| data, coords = self.roi.getArrayRegion(image.view(np.ndarray), self.imageItem, axes, returnMappedCoords=True) | ||
| #data, coords = self.roi.getArrayRegion(image.view(np.ndarray), self.imageItem, axes, returnMappedCoords=True) |
Member
There was a problem hiding this comment.
can you please delete this commented out line?
Member
|
Wonderful, CI passed, would you mind deleting the commented out line, and then I'll go ahead and merge. Thanks for thePR @meganbkratz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lavinia B found a bug when using an roi to select part of an image displayed in ImageView when pyqtgraph's imageAxisOrder option was set to 'row-major'. (See this forum thread: https://groups.google.com/forum/#!topic/pyqtgraph/SE8KcK2LOv4)
This PR is a fix for these bugs. The bugs were occurring in ImageView.roiChanged because accounting for the axis order was only partially implemented.