import numpy as np for lines 44 and 51#1161
Merged
j9ac9k merged 6 commits intopyqtgraph:developfrom May 30, 2020
Merged
Conversation
Member
|
Thanks for the PR @cclauss The CI doesn't like the change you made to test_exit_crash Fired up my own interpretter Probably should wrap that |
This issue will be fixed elsewhere.
Member
|
Thanks for this PR @cclauss , sort of amazing we haven't noticed this before. |
Contributor
Author
|
It can happen that another file has already imported numpy so things work but then if code get refactored, things break. This is safer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npin pyqtgraph/PlotData.py2. To fix CI, make sure thatcall_with_timeout()polls at least once.@j9ac9k @2xB Your reviews please.