Fix: Update axes after data is set#1159
Merged
j9ac9k merged 1 commit intopyqtgraph:developfrom Apr 9, 2020
Merged
Conversation
Member
|
Hi @2xB Thanks for the PR This CI failure that occurred is something that we've seen from minor changes, using having to do w/ the use of a QApplication (or lack-there-of). I'm really on the verge of skipping that specific test.... it's failing just on macOS/Qt5.9/Python3.6 pipeline.... |
Member
|
I really hate that this test failure is getting in the way of this PR, @ixjlyons as you were the last person to run into this, figure you may have an opinion? |
Contributor
Author
|
Let's test if this failure is consistent: |
Member
|
Good call on closing/opening ... I just reran the failed pipeline, which failed a second time for the same test... anyway, as it all passes now, I'm inclined to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On data changes on PlotCurveItems, bounds are updated before the new data is set, leading to axes not performing autoscaling directly. This PR changes the order of execution for setting data and updating bounds to fix that.
Fixes #1144