Prevent element-wise string comparison, second try#1024
Merged
j9ac9k merged 1 commit intopyqtgraph:developfrom Sep 13, 2019
Merged
Prevent element-wise string comparison, second try#1024j9ac9k merged 1 commit intopyqtgraph:developfrom
j9ac9k merged 1 commit intopyqtgraph:developfrom
Conversation
This was referenced Aug 20, 2019
Member
|
Re-running the CI on this merge request here: https://dev.azure.com/pyqtgraph/pyqtgraph/_build/results?buildId=452 EDIT: CI Passed with no errors, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #835, the former solution from #921 did not work to prevent
np.ndarray.__eq__to element-wise compare a string against an array. This Pull Request adds a type check so the comparison is only executed against strings, not against arrays. It is just copy-pasted from @flutefreak7 s comment on issue #835.Fixes #835.