Skip to content

ViewBox.updateScaleBox changed semantics in 0.12.4 #2237

@markotoplak

Description

@markotoplak

Short description

Since #2034, ViewBox.updateScaleBox needs to receive scene coordinates; before, it received parent coordinates. Our application (Orange) has uses derived view boxes, which now show wrong zooming rectangles in some cases.

I do understand we might be abusing the interface and that this method perhaps was not meant to be used externally. Should we adapt or is pyqtgraph perhaps going to roll this change back?

#2034 could easily be reworked slightly, either by creating a new method with new semantics and leaving the old as it were, or perhaps by adding a parameter to updateScaleBox that signals the new interface. I know neither of these options are as elegant as the current code, but on the other hand backward compatibility never is.

An example of working around this issue is Quasars/orange-spectroscopy#607

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions