Skip to content

Conversation

@XyC0212
Copy link
Contributor

@XyC0212 XyC0212 commented Apr 12, 2023

Support batched input

@XyC0212 XyC0212 requested a review from wang-chen April 12, 2023 12:59
@zitongzhan
Copy link
Contributor

zitongzhan commented Apr 13, 2023

Please commit your changes directly to the branch for PR. Each time you finished revising, you may re-request review.
If you are not familiar with git, please check out https://github.com/pypose/pypose/blob/zitongzhan-patch-CONTRIBUTING/CONTRIBUTING.md

@Murphy41 Murphy41 marked this pull request as draft April 18, 2023 03:43
XyC0212 and others added 10 commits April 18, 2023 12:04
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
Signed-off-by: Xiangyu Chen <89004488+XiangyuChen0212@users.noreply.github.com>
@Murphy41
Copy link
Member

Murphy41 commented May 1, 2023

Just tested, this module has bug given high batch broadcastable source and target shape, e.g., source(2, 100, 3) target (100, 3).

Hi Chen, I've fixed the bug 😄

@Murphy41 Murphy41 requested a review from wang-chen May 1, 2023 23:38
@Murphy41 Murphy41 requested a review from wang-chen May 2, 2023 02:17
@wang-chen wang-chen requested a review from Murphy41 May 3, 2023 17:44
@wang-chen wang-chen merged commit 7a85144 into main May 4, 2023
@wang-chen wang-chen deleted the ICP branch May 4, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add Module ICP

5 participants