Feature/epnp #184
Merged
Feature/epnp #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add naive point experiment to be consistent with paper's matlab implementation. Check numerical values with matlab.
- verified numerical values for dim=2,3 but not 4, due to rank of matrix is not sufficient. This is also why cpp code do not use dim=4
wang-chen
requested changes
Mar 2, 2023
Member
wang-chen
left a comment
There was a problem hiding this comment.
Following our meeting, better to give an API design first: showing how we want the user to use this module. Just like the example we provided in LM optimizer.
Signed-off-by: zitongzhan <zitongz3@illinois.edu>
Contributor
Author
wang-chen
approved these changes
Apr 10, 2023
jingnanshi
approved these changes
Apr 12, 2023
Contributor
jingnanshi
left a comment
There was a problem hiding this comment.
Great job! I just left a few minor comments.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#149
...) because of the limitations of svd and vmap functionsDiff with original implementation. Naming are changed to all lower case but correspondence are still identifiable.