Skip to content

Add language switcher UI#6624

Closed
nlhkabu wants to merge 1 commit intomasterfrom
6455-language-switcher
Closed

Add language switcher UI#6624
nlhkabu wants to merge 1 commit intomasterfrom
6455-language-switcher

Conversation

@nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Sep 11, 2019

Closes #6455

Adds a language switcher list in the PyPI footer:

lang-switch

Blocked by #6535

@woodruffw I'm assigning this PR to you, as it's done on my side, and just needs to be hooked in as you see fit

Note: the language names should not be translated.

@woodruffw
Copy link
Member

@nlhkabu I'm going to rebase #6535 on this so that we can merge the two simultaneously 🙂

@woodruffw
Copy link
Member

Proposing that we close this (and remove the "closes" tag to prevent the linked issue from closing) now that #6535 is based on it.

@nlhkabu nlhkabu closed this Sep 20, 2019
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Sep 20, 2019

Closed in favour of #6535

@nlhkabu nlhkabu deleted the 6455-language-switcher branch September 20, 2019 05:54
@brainwane
Copy link
Contributor

How can I locate this UI now? I think I don't see it at the bottom of pypi.org.

@brainwane
Copy link
Contributor

Oh, now I think I understand -- we haven't added any to the footer yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add language switcher to PyPI UI

3 participants