Split out this setup.py fix from https://github.com/pypa/virtualenv/pull/635 #638
Conversation
command name "test" also as the directory name to find tests.
|
I'm somewhat baffled by this, as I thought I guess the problem is a |
|
Will do when I get myself back on nix |
|
I think I had tracked it down to a _pytest/config.py, _preparseconfig. Someone better versed in this area should definitely double-check my assumptions on how this was working. def _prepareconfig(args=None, plugins=None):
if args is None:
args = sys.argv[1:]
|
|
Hmm, then perhaps this is an issue with pytest's example, |
|
I was wondering what the likelihood of these being adopted and merged into the mainline. |
There was a problem hiding this comment.
See http://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands - should this not be self.pytest_args = []?
Having said this, the tests for virtualenv are a bit of a mess and don't really follow the py.test standard discovery rules - see http://pytest.org/latest/goodpractises.html#test-discovery
I'd rather we fixed up the tests properly instead of hard-coding a tests directory that could cause us grief later...
|
Because this is old and based on 1.11 and virtualenv is now in a 13.X series, I'll re-submit. |
Fix default args for py.test to be "tests" instead of using the
command name "test" also as the directory name to find tests.