Fix for tests: Python 3.13.0a6 renamed pathmod to parser#2702
Merged
gaborbernat merged 4 commits intopypa:mainfrom Apr 17, 2024
Merged
Fix for tests: Python 3.13.0a6 renamed pathmod to parser#2702gaborbernat merged 4 commits intopypa:mainfrom
gaborbernat merged 4 commits intopypa:mainfrom
Conversation
gaborbernat
previously approved these changes
Apr 16, 2024
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
be8a3e4 to
023ec7d
Compare
gaborbernat
approved these changes
Apr 17, 2024
gaborbernat
requested changes
Apr 17, 2024
Contributor
gaborbernat
left a comment
There was a problem hiding this comment.
Fails on Windows, can you address please.
auto-merge was automatically disabled
April 17, 2024 00:19
Pull request was converted to draft
Contributor
Author
|
I see 4 failing checks (2x macos, ubuntu and docs), none can be attributed to these changes, windows tests pass. I don't know what to address. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2671 which reappeared in alpha6 as a result of upstream renaming the attribute.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder