Conversation
Signed-off-by: William Woodruff <william@astral.sh>
Member
sigmavirus24
left a comment
There was a problem hiding this comment.
What if we bump the minimum packaging version to not encounter this and clean things up instead of adding the mypy ignore?
Member
Author
That works for me! That'll be a big bump in terms of downstream integrators (since right now we test |
Signed-off-by: William Woodruff <william@astral.sh>
Contributor
|
We can add it to |
sigmavirus24
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tripping the CI in #1309 and on main.
packaging==26.1movespackaging.metadata.ExceptionGrouptopackaging.errors.ExceptionGroup, but re-exports that API throughpackaging.metadatafor backwards compatibility. However, that re-export isn't explicitly marked in__all__, so mypy flags it.We could patch around this or suppress it, but bumping to
>= 26.1is easiest.Here's the implicit re-export:
https://github.com/pypa/packaging/blob/b82413d6a1e5037b65aabc44154a97f0b2d63766/src/packaging/metadata.py#L21
CC @henryiii for opinions since I think
packaging.errorswas your change with pypa/packaging#1071 🙂