Apply distutils fix for parsing linker parameters#4959
Merged
Conversation
Previously, when parsing linker parameters for C++ targets, the CC variable was used to determine what the "prefix" of the command was in order to determine what the linker arguments were. If the value of LDCXXSHARED did not match CC, the first argument would be dropped as it was assumed to be the linker command. However, if the command was a wrapper, such as ccache, it could lead to compile problems as the generated command would be incorrect. In the following scenario: LDCXXSHARED="ccache g++ -shared -Wl,--enable-new-dtags" CC="ccache gcc" CXX="ccache g++" The command would be incorrectly parsed to: ccache g++ g++ -shared -Wl,--enable-new-dtags Now, the CXX value is used to improve the chances of parsing the linker arguments correctly to generate: ccache g++ -shared -Wl,--enable-new-dtags LDCXXSHARED and CXX still need to be in sync either in the environment or within the sysconfig variables in the CPython build for parsing to work correctly. The CXX value is now also respected when linking executable binaries. Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Address the following: * use the compiler's executable extension in asserts * remove any environment variables that may have been injected by CI * add a pragma to ignore a line without coverage Signed-off-by: Vincent Fazio <vfazio@gmail.com>
…arg-parse Respect CXX when parsing linker parameters for UNIX c++ targets. Closes pypa/distutils#355
Member
Author
|
Releasing as v79.0.1. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)